Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move setting of DSCMachineStatus to helper function #408

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Move setting of DSCMachineStatus to helper function #408

merged 1 commit into from
Feb 8, 2019

Conversation

mhendric
Copy link
Contributor

@mhendric mhendric commented Feb 7, 2019

Pull Request (PR) description

Move setting of DSCMachineStatus to helper function

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@mhendric
Copy link
Contributor Author

mhendric commented Feb 7, 2019

@manigandan-jegannathan-developer can you give this code change a review when you get a chance? Thanks.

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #408 into dev will increase coverage by 0.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #408      +/-   ##
==========================================
+ Coverage   40.17%   40.18%   +0.01%     
==========================================
  Files          39       39              
  Lines        4767     4768       +1     
==========================================
+ Hits         1915     1916       +1     
  Misses       2852     2852
Impacted Files Coverage Δ
...ber/MSFT_xExchDatabaseAvailabilityGroupMember.psm1 35.13% <0%> (ø) ⬆️
...chJetstressCleanup/MSFT_xExchJetstressCleanup.psm1 5.5% <0%> (ø) ⬆️
...urces/MSFT_xExchJetstress/MSFT_xExchJetstress.psm1 8.6% <0%> (ø) ⬆️
Modules/xExchangeHelper.psm1 96.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6edb063...7db42c3. Read the comment docs.

@mhendric mhendric added the needs review The pull request needs a code review. label Feb 7, 2019
@jegannathanmaniganadan
Copy link

@mhendric Looks fine to me from PSSA perspective.

@mhendric mhendric merged commit 47630a4 into dsccommunity:dev Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The pull request needs a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSSA complains about Suppression Message Attribute being used wrongly
3 participants