Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xUser: add NewName property #719

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gaelicWizard
Copy link

@gaelicWizard gaelicWizard commented May 23, 2021

Pull Request (PR) description

Adds optional parameter NewName to User resource to allow setting SamAccountName property separately. This requires that UserName be specified using something other than the SamAccountName, e.g. SID.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

gaelicWizard and others added 4 commits May 22, 2021 21:45
Add NewName property to allow setting the name of the user; this requires that the UserName property be specified with something other than the SamAccountName (e.g., the SID).
Don’t allow the NewName parameter to set SamAccountName when creating an entirely new user.
@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #719 (50d4159) into main (dcadffd) will decrease coverage by 0%.
The diff coverage is 50%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #719   +/-   ##
===================================
- Coverage    72%    72%   -1%     
===================================
  Files        30     30           
  Lines      4427   4457   +30     
===================================
+ Hits       3213   3228   +15     
- Misses     1214   1229   +15     
Impacted Files Coverage Δ
...Resources/DSC_xUserResource/DSC_xUserResource.psm1 53% <50%> (-1%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant