Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Fix iam instance profile #376

Merged
merged 2 commits into from
Oct 22, 2017
Merged

Conversation

chroju
Copy link
Contributor

@chroju chroju commented Oct 9, 2017

Fix issue #374 .

Because the "roles" argument in aws_iam_instance_profile is deprecated,
use "role" instead in tf and tfstate.
cf: AWS: aws_iam_instance_profile - Terraform by HashiCorp

In addition, remove the test case with 0 role. In this case, terraform will output the following error.

Error applying plan:

1 error(s) occurred:

* aws_iam_instance_profile.test_profile: 1 error(s) occurred:

* aws_iam_instance_profile.test_profile: Either `role` or `roles` (deprecated) must be specified when creating an IAM Instance Profile

@coveralls
Copy link

coveralls commented Oct 9, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 45053e5 on chroju:fix_iam_instance_profile into f4e3040 on dtan4:master.

@dtan4
Copy link
Owner

dtan4 commented Oct 22, 2017

(mistaken! this comment was moved to #370 (comment))

@dtan4
Copy link
Owner

dtan4 commented Oct 22, 2017

This field change was introduced at hashicorp/terraform#13130 and released at Terraform v0.9.3.

@dtan4
Copy link
Owner

dtan4 commented Oct 22, 2017

LGTM 👍 Thanks ❗️

@dtan4 dtan4 merged commit 9a0cf98 into dtan4:master Oct 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants