Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add construct_ prefix to name of private construct functions #401

Merged
merged 1 commit into from
Dec 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/context.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ mod ext {
C: Display + Send + Sync + 'static,
{
let backtrace = backtrace_if_absent!(&self);
Error::from_context(context, self, backtrace)
Error::construct_from_context(context, self, backtrace)
}
}

Expand Down Expand Up @@ -96,7 +96,7 @@ impl<T> Context<T, Infallible> for Option<T> {
// backtrace.
match self {
Some(ok) => Ok(ok),
None => Err(Error::from_display(context, backtrace!())),
None => Err(Error::construct_from_display(context, backtrace!())),
}
}

Expand All @@ -107,7 +107,7 @@ impl<T> Context<T, Infallible> for Option<T> {
{
match self {
Some(ok) => Ok(ok),
None => Err(Error::from_display(context(), backtrace!())),
None => Err(Error::construct_from_display(context(), backtrace!())),
}
}
}
Expand Down
20 changes: 12 additions & 8 deletions src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ impl Error {
E: StdError + Send + Sync + 'static,
{
let backtrace = backtrace_if_absent!(&error);
Error::from_std(error, backtrace)
Error::construct_from_std(error, backtrace)
}

/// Create a new error object from a printable error message.
Expand Down Expand Up @@ -82,12 +82,12 @@ impl Error {
where
M: Display + Debug + Send + Sync + 'static,
{
Error::from_adhoc(message, backtrace!())
Error::construct_from_adhoc(message, backtrace!())
}

#[cfg(any(feature = "std", not(anyhow_no_core_error)))]
#[cold]
pub(crate) fn from_std<E>(error: E, backtrace: Option<Backtrace>) -> Self
pub(crate) fn construct_from_std<E>(error: E, backtrace: Option<Backtrace>) -> Self
where
E: StdError + Send + Sync + 'static,
{
Expand All @@ -113,7 +113,7 @@ impl Error {
}

#[cold]
pub(crate) fn from_adhoc<M>(message: M, backtrace: Option<Backtrace>) -> Self
pub(crate) fn construct_from_adhoc<M>(message: M, backtrace: Option<Backtrace>) -> Self
where
M: Display + Debug + Send + Sync + 'static,
{
Expand Down Expand Up @@ -142,7 +142,7 @@ impl Error {
}

#[cold]
pub(crate) fn from_display<M>(message: M, backtrace: Option<Backtrace>) -> Self
pub(crate) fn construct_from_display<M>(message: M, backtrace: Option<Backtrace>) -> Self
where
M: Display + Send + Sync + 'static,
{
Expand Down Expand Up @@ -172,7 +172,11 @@ impl Error {

#[cfg(any(feature = "std", not(anyhow_no_core_error)))]
#[cold]
pub(crate) fn from_context<C, E>(context: C, error: E, backtrace: Option<Backtrace>) -> Self
pub(crate) fn construct_from_context<C, E>(
context: C,
error: E,
backtrace: Option<Backtrace>,
) -> Self
where
C: Display + Send + Sync + 'static,
E: StdError + Send + Sync + 'static,
Expand Down Expand Up @@ -202,7 +206,7 @@ impl Error {

#[cfg(any(feature = "std", not(anyhow_no_core_error)))]
#[cold]
pub(crate) fn from_boxed(
pub(crate) fn construct_from_boxed(
error: Box<dyn StdError + Send + Sync>,
backtrace: Option<Backtrace>,
) -> Self {
Expand Down Expand Up @@ -562,7 +566,7 @@ where
#[cold]
fn from(error: E) -> Self {
let backtrace = backtrace_if_absent!(&error);
Error::from_std(error, backtrace)
Error::construct_from_std(error, backtrace)
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/kind.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl Adhoc {
where
M: Display + Debug + Send + Sync + 'static,
{
Error::from_adhoc(message, backtrace!())
Error::construct_from_adhoc(message, backtrace!())
}
}

Expand Down Expand Up @@ -116,6 +116,6 @@ impl Boxed {
#[cold]
pub fn new(self, error: Box<dyn StdError + Send + Sync>) -> Error {
let backtrace = backtrace_if_absent!(&*error);
Error::from_boxed(error, backtrace)
Error::construct_from_boxed(error, backtrace)
}
}
Loading