Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CxxVector<*mut T> and CxxVector<*const T> #1375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for CxxVector<*mut T> and CxxVector<*const T> #1375

wants to merge 1 commit into from

Conversation

makai410
Copy link

@makai410 makai410 commented Sep 17, 2024 •
edited
Loading

Fixes #795 .

@makai410 makai410 mentioned this pull request Sep 18, 2024
Open
fee1-dead
fee1-dead reviewed Sep 18, 2024
View reviewed changes
gen/src/write.rs Outdated Show resolved Hide resolved
syntax/instantiate.rs Outdated Show resolved Hide resolved
@makai410 makai410 force-pushed the integrate-ptr-vec-wip branch from 7f18ebd to 6fccd3a Compare September 27, 2024 15:55
@makai410 makai410 marked this pull request as draft September 27, 2024 16:04
@makai410 makai410 force-pushed the integrate-ptr-vec-wip branch from 49aa408 to dd59cd1 Compare September 27, 2024 16:26
@makai410 makai410 marked this pull request as ready for review September 27, 2024 16:27
@makai410 makai410 force-pushed the integrate-ptr-vec-wip branch from dd59cd1 to 84f362d Compare October 30, 2024 08:36
@makai410
Copy link
Author

I just updated the PR with code cleanup and redundancy removal. Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fee1-dead fee1-dead fee1-dead left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CxxVector<*mut Thing>
2 participants
@makai410 @fee1-dead