Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VersionReq::contains_op #212

Closed
wants to merge 1 commit into from
Closed

Add VersionReq::contains_op #212

wants to merge 1 commit into from

Conversation

thiagoarrais
Copy link

This pull request adds a contains_op method for checking if a VersionReq contains some Op. It also exposes the (previously) internal Op and WildcardVersion enums for use by the crate users.

Fixes #191

@thiagoarrais
Copy link
Author

@hbina: please take a look at the included tests and let me know if this is what cargo needs. I'm not really sure if 1.0.0 should count as using Compatible or not (besides being equivalent), for instance.

dtolnay
dtolnay reviewed May 25, 2021
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think this is made unnecessary by the VersionReq design in 1.0.0, in which downstream code is able to perform this scan itself.

@dtolnay dtolnay closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a method to check if all Predicates in some VersionReq contains some Op
2 participants
@thiagoarrais @dtolnay