Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark #[automatically_derived] for generated impls #322

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Mark #[automatically_derived] for generated impls #322

merged 1 commit into from
Sep 22, 2024

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Sep 22, 2024

Because

  1. They are indeed automatically derived.
  2. It does not break MSRV 1.56.
  3. Avoid testing Display and Error methods (and each branches inside them) for test coverage. coverage: Don't instrument #[automatically_derived] functions rust-lang/rust#120185

dtolnay
dtolnay approved these changes Sep 22, 2024
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 023f036 into dtolnay:master Sep 22, 2024
10 checks passed
@oxalica oxalica deleted the feat/mark-auto-derived branch September 22, 2024 17:53
@wcampbell0x2a wcampbell0x2a mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oxalica @dtolnay