Propagate allows to auto-generated impls
#393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As noted in dtolnay#392, built-in derive macros propagate `allow` attributes to auto-generated `impl` blocks. For consistency, the same is done for `thiserror::Error` derive macro.
dtolnay
reviewed
Dec 6, 2024
| // } | ||
| // } | ||
| // ``` | ||
| attrs.allows = Some(attr); |
There was a problem hiding this comment.
This would drop all but the last allow attribute. When there are multiple attributes, the expected behavior would be that they all make it to the impl, not just the last one.
There was a problem hiding this comment.
You're right; the only scenario I considered was and tested was with all allows listed in one attribute.
| @@ -115,6 +117,30 @@ pub fn get(input: &[Attribute]) -> Result<Attrs> { | |||
| original: attr, | |||
| span, | |||
| }); | |||
| } else if attr.path().is_ident("allow") { | |||
There was a problem hiding this comment.
derive(Debug) propagates some other attributes. I didn't track down exactly which ones but I tested with warn.
|
Thanks for the PR! Let's solve the original issue with deprecation a different way as pointed out in #392 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #392, built-in derive macros propagate
allowattributes to auto-generatedimplblocks. For consistency, the same is done forthiserror::Errorderive macro.Note for reviewers: I might have omitted some places where propagation should be done.
Fixes: #392