Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the limit on input size for diff gen #297

Closed
wants to merge 1 commit into from

Conversation

its-the-shrimp
Copy link

@its-the-shrimp its-the-shrimp commented Dec 2, 2024

I'm using this version of trybuild for my tests as the lack of diffs for non-trivial compiler outputs is extremely annoying, as those are the ones where proper diffs are the most important.

I found that the removed if condition is 4 years old, I wonder if the concern is still up to date

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to protect from dtolnay/dissimilar#12.

Switching to a more robust diff algorithm would be a more viable option.

@dtolnay dtolnay closed this Dec 2, 2024
@its-the-shrimp
Copy link
Author

Would you accept a PR replacing dissimilar with diffy? It seems to be more mature

@dtolnay
Copy link
Owner

dtolnay commented Dec 8, 2024

That crate is specifically for generating (and coloring) .patch file format, which is not the format that I would prefer trybuild's output to take. It is not compatible with intraline highlighting. The use case that .patch files are designed for is very different. It is optimized for applying one set of changes to a source file that already contains a different set of changes, e.g. in the context of source control. The crate also has many fewer downloads than dissimilar. I am not confident that it would turn out to be mature in practical usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants