🏷️(worker) Prefer "import type" over raw "import" (#4420)

While raw "import" works well, it does carry an extra cost: - bundlers may not optimize it as much as they can and may require to import the linked file even if they don't need to assess typings - it may produce less optimized bundles (we may refer to unneeded files and thus delay some operations)
dubzzz · Nov 9, 2023 · be9f8ef · be9f8ef
1 parent 65f81d9
commit be9f8ef
Show file tree

Hide file tree

Showing 20 changed files with 27 additions and 33 deletions.
diff --git a/.yarn/versions/7b36cbca.yml b/.yarn/versions/7b36cbca.yml
@@ -0,0 +1,3 @@
+releases:
+  "@fast-check/jest": patch
+  "@fast-check/worker": minor
diff --git a/packages/jest/package.json b/packages/jest/package.json
@@ -59,7 +59,7 @@
     "fast-check": "^3.0.0"
   },
   "peerDependencies": {
-    "@fast-check/worker": "~0.0.7",
+    "@fast-check/worker": "~0.0.7 || ~0.1.0",
     "@jest/expect": ">=28.0.0",
     "@jest/globals": ">=25.5.2"
   },

diff --git a/packages/worker/src/internals/MainThreadRunner.ts b/packages/worker/src/internals/MainThreadRunner.ts
@@ -1,8 +1,8 @@
 import fc from 'fast-check';
-import { type PropertyArbitraries, type WorkerProperty } from './SharedTypes.js';
+import type { PropertyArbitraries, WorkerProperty } from './SharedTypes.js';
 import { BasicPool } from './worker-pool/BasicPool.js';
 import { Lock } from './lock/Lock.js';
-import { IWorkerPool, PooledWorker } from './worker-pool/IWorkerPool.js';
+import type { IWorkerPool, PooledWorker } from './worker-pool/IWorkerPool.js';
 import { OneTimePool } from './worker-pool/OneTimePool.js';
 import { GlobalPool } from './worker-pool/GlobalPool.js';
 

diff --git a/packages/worker/src/internals/NoopWorkerProperty.ts b/packages/worker/src/internals/NoopWorkerProperty.ts
@@ -1,11 +1,5 @@
-import {
-  type IAsyncPropertyWithHooks,
-  type Value,
-  type Stream,
-  type PreconditionFailure,
-  type PropertyFailure,
-} from 'fast-check';
-import { type WorkerProperty } from './SharedTypes.js';
+import type { IAsyncPropertyWithHooks, Value, Stream, PreconditionFailure, PropertyFailure } from 'fast-check';
+import type { WorkerProperty } from './SharedTypes.js';
 
 /**
  * NoopWorkerProperty is a placeholder instance of property returned

diff --git a/packages/worker/src/internals/SharedTypes.ts b/packages/worker/src/internals/SharedTypes.ts
@@ -1,5 +1,5 @@
 import type { Arbitrary, IAsyncPropertyWithHooks } from 'fast-check';
-import { type PoolToWorkerMessage, type WorkerToPoolMessage } from './worker-pool/IWorkerPool.js';
+import type { PoolToWorkerMessage, WorkerToPoolMessage } from './worker-pool/IWorkerPool.js';
 
 export type PropertyArbitraries<Ts extends unknown[]> = {
   [K in keyof Ts]: Arbitrary<Ts[K]>;

diff --git a/packages/worker/src/internals/worker-pool/GlobalPool.ts b/packages/worker/src/internals/worker-pool/GlobalPool.ts
@@ -1,5 +1,5 @@
 import { BasicPool } from './BasicPool.js';
-import { IWorkerPool, PooledWorker } from './IWorkerPool.js';
+import type { IWorkerPool, PooledWorker } from './IWorkerPool.js';
 
 const poolPerFile = new Map<string, BasicPool<unknown, unknown>>();
 const pendingTerminationPerFile = new Map<string, ReturnType<typeof setTimeout>>();

diff --git a/packages/worker/src/internals/worker-pool/OneTimePool.ts b/packages/worker/src/internals/worker-pool/OneTimePool.ts
@@ -1,5 +1,5 @@
 import { BasicPool } from './BasicPool.js';
-import { IWorkerPool, PooledWorker } from './IWorkerPool.js';
+import type { IWorkerPool, PooledWorker } from './IWorkerPool.js';
 
 /**
  * Pool never re-using already spawned worker.

diff --git a/packages/worker/src/internals/worker-runner/NoWorkerRunner.ts b/packages/worker/src/internals/worker-runner/NoWorkerRunner.ts
@@ -1,5 +1,5 @@
-import { type MessagePort } from 'node:worker_threads';
-import { type MainThreadToWorkerMessage, type WorkerToMainThreadMessage } from '../SharedTypes.js';
+import type { MessagePort } from 'node:worker_threads';
+import type { MainThreadToWorkerMessage, WorkerToMainThreadMessage } from '../SharedTypes.js';
 
 /**
  * Setup the fallback worker listening to all predicates and rejecting any that has never been registered

diff --git a/packages/worker/src/internals/worker-runner/WorkerRunner.ts b/packages/worker/src/internals/worker-runner/WorkerRunner.ts
@@ -1,9 +1,5 @@
-import { type MessagePort } from 'node:worker_threads';
-import {
-  type MainThreadToWorkerMessage,
-  type PropertyPredicate,
-  type WorkerToMainThreadMessage,
-} from '../SharedTypes.js';
+import type { MessagePort } from 'node:worker_threads';
+import type { MainThreadToWorkerMessage, PropertyPredicate, WorkerToMainThreadMessage } from '../SharedTypes.js';
 
 /**
  * Setup a worker listening to parentPort and able to run a single time for a given predicate

diff --git a/packages/worker/src/main.ts b/packages/worker/src/main.ts
@@ -4,7 +4,7 @@ import { assert as fcAssert, type IAsyncProperty, type IProperty, type Parameter
 import { runWorker } from './internals/worker-runner/WorkerRunner.js';
 import { runMainThread } from './internals/MainThreadRunner.js';
 import { NoopWorkerProperty } from './internals/NoopWorkerProperty.js';
-import { type PropertyArbitraries, type PropertyPredicate, type WorkerProperty } from './internals/SharedTypes.js';
+import type { PropertyArbitraries, PropertyPredicate, WorkerProperty } from './internals/SharedTypes.js';
 import { runNoWorker } from './internals/worker-runner/NoWorkerRunner.js';
 
 let lastPredicateId = 0;

diff --git a/packages/worker/test/e2e/blockEventLoop.spec.ts b/packages/worker/test/e2e/blockEventLoop.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/e2e/concurrentAssert.spec.ts b/packages/worker/test/e2e/concurrentAssert.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/e2e/failing.spec.ts b/packages/worker/test/e2e/failing.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/e2e/passing.spec.ts b/packages/worker/test/e2e/passing.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/e2e/predicateIsolation.spec.ts b/packages/worker/test/e2e/predicateIsolation.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/e2e/propertyIsolation.spec.ts b/packages/worker/test/e2e/propertyIsolation.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/e2e/unregistered.spec.ts b/packages/worker/test/e2e/unregistered.spec.ts
@@ -1,5 +1,5 @@
 import { isMainThread } from 'node:worker_threads';
-import { type Parameters } from 'fast-check';
+import type { Parameters } from 'fast-check';
 import { assert } from '@fast-check/worker';
 
 /* eslint-disable @typescript-eslint/ban-ts-comment */

diff --git a/packages/worker/test/internals/lock/Lock.spec.ts b/packages/worker/test/internals/lock/Lock.spec.ts
@@ -1,4 +1,5 @@
-import { AcquiredLock, Lock } from '../../../src/internals/lock/Lock.js';
+import type { AcquiredLock } from '../../../src/internals/lock/Lock.js';
+import { Lock } from '../../../src/internals/lock/Lock.js';
 
 describe('Lock', () => {
   it('should be able to take the first lock', async () => {

diff --git a/packages/worker/test/internals/worker-pool/BasicPool.spec.ts b/packages/worker/test/internals/worker-pool/BasicPool.spec.ts
@@ -1,4 +1,4 @@
-import { PoolToWorkerMessage, WorkerToPoolMessage } from '../../../src/internals/worker-pool/IWorkerPool.js';
+import type { PoolToWorkerMessage, WorkerToPoolMessage } from '../../../src/internals/worker-pool/IWorkerPool.js';
 import { BasicPool } from '../../../src/internals/worker-pool/BasicPool.js';
 // @ts-expect-error - It should normally be "* as WorkerThreadsMock" but it does not work anymore since we switched to babel (instead of ts-jest)
 import WorkerThreadsMock from 'node:worker_threads';

diff --git a/yarn.lock b/yarn.lock
@@ -2797,7 +2797,7 @@ __metadata:
     jest-jasmine2: ^29.7.0
     typescript: ~5.2.2
   peerDependencies:
-    "@fast-check/worker": ~0.0.7
+    "@fast-check/worker": ~0.0.7 || ~0.1.0
     "@jest/expect": ">=28.0.0"
     "@jest/globals": ">=25.5.2"
   peerDependenciesMeta: