Fix test to trigger append error #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot of the PR, I've Included it as part of #427 (sorry, the squash messed up the history and didnt auto-close this PR) |
|
You're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
test_appender_errortest, which was failing due to changes in DuckDB’s handling of virtual generated columns. DuckDB treatsfoobar_splitas a virtual generated column, meaning its value is computed at query time and cannot be inserted into. Previously, the test assumed appending to thefoobarcolumn alone would trigger an error, but DuckDB allowed the insertion, causing the test to fail. By addingfoobar_int, the test now correctly validates that appending an incomplete row still fails as expected.