Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devtools panel with improved UI #2408

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

tagawa
Copy link
Contributor

@tagawa tagawa commented Jan 5, 2024

Reviewer:
@sammacbeth
CC:
@GuiltyDolphin @jonathanKingston

Description:

The current devtools panel is functional, but to make it easier to use should have a better UI.
This PR uses the existing extension styles (in base.css) and triggers page reload when protections are toggled, to save clicks.
See internal task: https://app.asana.com/0/0/1206280121954708/f

Steps to test this PR:

Once built, open devtools-panel.html
Check that the page layout is not broken.
Check that the buttons still work, and that protection buttons also trigger a page reload.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Clicking the protections buttons will also reload the target web page, saving time.
@sammacbeth sammacbeth merged commit 8ec0f10 into main Jan 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants