Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect internal users and add an extra section to settings for them. #2480

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

sammacbeth
Copy link
Collaborator

Reviewer:

Description:

This mirrors how we detect internal users on other platforms (for example apple platforms, in order to add a isInternalUser flag to settings. This can be used to expose additional settings in the options menu.

Steps to test this PR:

  1. Open settings - note that the sections are as before.
  2. Visit use-login.duckduckgo.com and login with DDG SSO.
  3. Return to the settings page - there should not be a new 'Interal settings' section.

@sammacbeth sammacbeth requested a review from kzar March 19, 2024 11:26
Copy link
Collaborator

@kzar kzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but as mentioned in Asana I want to double check about a privacy review before we merge this. Edit: Privacy concerns addressed in Asana.

@kzar kzar marked this pull request as draft March 25, 2024 11:25
@kzar kzar marked this pull request as ready for review March 25, 2024 12:48
@sammacbeth sammacbeth merged commit 09f8b35 into main Mar 25, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants