Post international Privacy Pro launch cleanup #3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
miasma13
commented
Jan 8, 2025
samsymons
approved these changes
Jan 9, 2025
miasma13
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 9, 2025
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1203936086921904/1208836865988474/f iOS PR: duckduckgo/iOS#3778 macOS PR: duckduckgo/macos-browser#3714 What kind of version bump will this require?: Major/Minor/Patch **Optional**: CC: @federicocappelli **Description**: Post launch remove isLaunchedROW and isLaunchedROWOverride feature flags and clean related business logic **Steps to test this PR**: See client PRs, no functional changes. **OS Testing**: * [ ] iOS * [ ] macOS --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203936086921904/1208836865988474/f
CC: @federicocappelli
Description:
Post launch remove isLaunchedROW and isLaunchedROWOverride feature flags and clean related business logic
Steps to test this PR:
Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template