Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test #3833

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Jan 20, 2025

Task/Issue URL: https://app.asana.com/0/1205237866452338/1209195419020322/f

Description: Fix Flaky integration test. the etag could be nil at the beginning

Steps to test this PR:

  1. CI is green

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio changed the base branch from main to release/ios/7.154.0 January 20, 2025 14:36
@SabrinaTardio SabrinaTardio requested a review from ayoy January 20, 2025 14:38
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unit tests passed :)

@SabrinaTardio SabrinaTardio merged commit db76a93 into release/ios/7.154.0 Jan 20, 2025
26 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/fix-integration-test branch January 20, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants