Added support for the new ephemeral topic feature #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops. Failed the build because travis CI uses stable nsq :-) Do you guys have a process for this? maybe there is a branch for beta? |
|
Here is the issue in the nsq code base: nsqio/nsq#305 |
|
@clintberry Since this isn't in any release, I would hesitate to put it on master. However, we can get a branch going for in-development NSQ functionality where this can live. I'll try to find some time over the next couple of days to make this work. |
|
That makes perfect sense. We can wait until they release the next version of NSQ with this feature enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of NSQ supports ephemeral topics for true pub sub functionality. I changed the regex for the topic name validation to support this.