Fix unsafe binary to term #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltfy
force-pushed
the
waltfy/fix-unsafe-binary-to-term
branch
from
83aec31
to
b1a7e9d
Compare
In this commit we introduce a test that ensures that an error is thrown and that we do not execute the Remote Code Execution (RCE) function.
waltfy
force-pushed
the
waltfy/fix-unsafe-binary-to-term
branch
from
b1a7e9d
to
0dcd533
Compare
added 4 commits
August 17, 2020 18:28
Plug.Crypto contains a function non_executable_binary_to_term/2, which raises if it detects an executable term such as an anonnymous function. We will use this to prevent remote code execution.
Instead of using :erlang.binary_to_term we'll use Plug.Crypto.non_executable_binary_to_term/2 which only deserializes non-executable terms.
waltfy
force-pushed
the
waltfy/fix-unsafe-binary-to-term
branch
from
0dcd533
to
e38524a
Compare
maartenvanvliet
added a commit
to maartenvanvliet/quarto
that referenced
this pull request
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a Remote Code Execution vulnerability, which was detected by @p-.. Instead of using the potentially unsafe
:erlang.binary_to_term/2, we instead usePlug.Crypto.non_executable_binary_to_term/2— this is effectively a drop in replacement that throws an exception when it detects unsafe terms, preventing its execution.TODO:
paginatorpaginator