-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OP v1 tables #1376
Update OP v1 tables #1376
Conversation
@@ -50,6 +50,11 @@ Layerzero Layer Zero | |||
Xtoken xToken | |||
Instadapp InstaDapp | |||
Lifi LiFi | |||
Optimistic Exporer Optimistic Explorer - Get Started NFT | |||
ironbank Iron Bank | |||
Ironbank Iron Bank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postgres seems to treat line 54 & 55 as the same -- likely not case sensitive, leading to duplicates and failed load. i had to remove line 55 to run. will this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i ran if you wanted to check output
ironbank Iron Bank | ||
Ironbank Iron Bank | ||
iron_bank Iron Bank | ||
Iron_bank Iron Bank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closing this with the outstanding comments. please open new PR if the changes didn't cover all that was needed
Brief comments on the purpose of your changes:
Add tokens, contract creators, name mapping.
For Dune Engine V2
I've checked that:
lowercase_snake_cased
When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.