Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OP v1 tables #1376

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Update OP v1 tables #1376

merged 5 commits into from
Aug 19, 2022

Conversation

MSilb7
Copy link
Contributor

@MSilb7 MSilb7 commented Aug 14, 2022

Brief comments on the purpose of your changes:
Add tokens, contract creators, name mapping.


For Dune Engine V2
I've checked that:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased

When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.

@MSilb7 MSilb7 changed the title [DRAFT] Update contract_creator_address_list.sql Update OP v1 tables Aug 16, 2022
@MSilb7 MSilb7 marked this pull request as ready for review August 16, 2022 12:48
@@ -50,6 +50,11 @@ Layerzero Layer Zero
Xtoken xToken
Instadapp InstaDapp
Lifi LiFi
Optimistic Exporer Optimistic Explorer - Get Started NFT
ironbank Iron Bank
Ironbank Iron Bank
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postgres seems to treat line 54 & 55 as the same -- likely not case sensitive, leading to duplicates and failed load. i had to remove line 55 to run. will this work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ran if you wanted to check output

ironbank Iron Bank
Ironbank Iron Bank
iron_bank Iron Bank
Iron_bank Iron Bank
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing this with the outstanding comments. please open new PR if the changes didn't cover all that was needed

@jeff-dude jeff-dude merged commit 5f91de5 into duneanalytics:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants