Adds Clipper Coves to dex.trades on Optimism #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aothman i can begin working on this, but in the meantime, can you update the PR to reflect our new repo structure? note that this directory now lives within our 'deprecated_v1' root directory |
jeff-dude
requested changes
Aug 26, 2022
|
@jeff-dude I believe I've done this now but please let me know if it doesn't fit your expectations. It looks like the whole repo changed right after this PR was created! |
jeff-dude
approved these changes
Aug 29, 2022
yep, we changed the repo to optimize for spellbook and new spells on v2 engine. would love to help get you on board, seems like clipper is a great fit to roll into the new dex trades there, as it's cross-chain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief comments on the purpose of your changes:
Clipper Coves recently launched on Optimism, allowing users to trade arbitrary tokens.
This PR, based on Clipper Coves Polygon, adds Coves support to dex.trades on Optimism.