Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transfers_optimism_eth.sql #1418

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Update transfers_optimism_eth.sql #1418

merged 2 commits into from
Aug 24, 2022

Conversation

dot2dotseurat
Copy link
Collaborator

Brief comments on the purpose of your changes:
bug in incremental block

For Dune Engine V2
I've checked that:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased

When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.

@soispoke soispoke removed the request for review from jeff-dude August 24, 2022 01:51
@soispoke soispoke dismissed jeff-dude’s stale review August 24, 2022 01:55

changes were made

@soispoke soispoke merged commit f7e5eb5 into master Aug 24, 2022
@jeff-dude jeff-dude deleted the dot2dotseurat-patch-1 branch August 24, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants