Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optimism Tables to Dune Explorer UI #1429

Merged
merged 14 commits into from
Aug 26, 2022

Conversation

chuxinh
Copy link
Contributor

@chuxinh chuxinh commented Aug 25, 2022

Brief comments on the purpose of your changes:

Adding recently added and existing OP tables to front end explorer UI.
Also updated the alias of transfers_optimism_eth to eth. Want it to show up as eth as table name instead of the following
image

Hope this won't break anything 🙏

For Dune Engine V2
I've checked that:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased

When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.

macros/alter_table_properties.sql Outdated Show resolved Hide resolved
@jeff-dude
Copy link
Member

changing the name to 'eth' is fine, it'll create a new view and the old one will linger. we will need to manually clean that up post-deploy

@chuxinh chuxinh marked this pull request as ready for review August 26, 2022 03:07
@chuxinh chuxinh requested a review from jeff-dude August 26, 2022 03:07
@chuxinh
Copy link
Contributor Author

chuxinh commented Aug 26, 2022

Thanks @jeff-dude updated everything here.
If you can let me know how i can bring up those csv files related to OVM1 I'd like to add them here too. Or a separate PR :D

@jeff-dude
Copy link
Member

jeff-dude commented Aug 26, 2022

Thanks @jeff-dude updated everything here. If you can let me know how i can bring up those csv files related to OVM1 I'd like to add them here too. Or a separate PR :D

i think this relates to what we're talking about in TG, right? let's follow up there

@jeff-dude jeff-dude merged commit 9eeb25f into duneanalytics:main Aug 26, 2022
@chuxinh chuxinh deleted the update-table-properties branch September 5, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants