Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementing materialization strategy for all incremental tables #1461

Conversation

soispoke
Copy link
Contributor

@soispoke soispoke commented Aug 30, 2022

Brief comments on the purpose of your changes:
I'm curious what you think of this one @aalan3, did I go too far and implemented this too much of was there a lot of places where it was missing ?

For Dune Engine V2
I've checked that:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased

When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.

@height
Copy link

height bot commented Aug 30, 2022

This pull request has been linked to 1 task:

  • T-15761 follow up on improving materialization strategies for incremental tables (unlink task)

💡Tip: Add "Close T-15761" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@jeff-dude
Copy link
Member

left comments in height

@jeff-dude
Copy link
Member

lgtm after the minor comments above

@soispoke
Copy link
Contributor Author

soispoke commented Sep 1, 2022

Thanks @jeff-dude and @aalan3

@soispoke soispoke requested a review from jeff-dude September 1, 2022 01:42
@jeff-dude jeff-dude merged commit e8a2d5f into main Sep 1, 2022
@jeff-dude jeff-dude deleted the T-15761-follow-up-on-improving-materialization-strategies-for-incremental-tables branch September 1, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants