-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish implementing materialization strategy for all incremental tables #1461
Merged
jeff-dude
merged 6 commits into
main
from
T-15761-follow-up-on-improving-materialization-strategies-for-incremental-tables
Sep 1, 2022
Merged
Finish implementing materialization strategy for all incremental tables #1461
jeff-dude
merged 6 commits into
main
from
T-15761-follow-up-on-improving-materialization-strategies-for-incremental-tables
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to 1 task:
|
left comments in height |
jeff-dude
requested changes
Aug 31, 2022
lgtm after the minor comments above |
Thanks @jeff-dude and @aalan3 |
…on-strategies-for-incremental-tables
jeff-dude
approved these changes
Sep 1, 2022
jeff-dude
deleted the
T-15761-follow-up-on-improving-materialization-strategies-for-incremental-tables
branch
September 1, 2022 18:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief comments on the purpose of your changes:
I'm curious what you think of this one @aalan3, did I go too far and implemented this too much of was there a lot of places where it was missing ?
For Dune Engine V2
I've checked that:
lowercase_snake_cased
When you are ready for a review, tag duneanalytics/data-experience. We will re-open your forked pull request as an internal pull request. Then your spells will run in dbt and the logs will be avaiable in Github Actions DBT Slim CI. This job will only run the models and tests changed by your PR compared to the production project.