Skip to content

Commit

Permalink
Update patch set 4
Browse files Browse the repository at this point in the history 
Patch Set 4:

Sorry, but this is not the way to do that. Registry key approach was discussed downstream in nodejs, Heath Stewart who is responsible for the VS installer said explicitly that the registry entry is not supported (nodejs/node-gyp#1103 (comment))

In node-gyp we used Rafael's powershell script that can query VS COM server (nodejs/node-gyp#1130). We used that to find VS and set environment variables. IMHO we should do the same thing here.

Patch-set: 4
  • Loading branch information
Gerrit User 1184479 authored and Gerrit Code Review committed Mar 16, 2017
1 parent 2bfe6f7 commit 9bee7d5
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 9bee7d5

Please sign in to comment.