Fix syncing when ancestors contain file basename #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, renaming a file through the header fails when the current file basename is contained in the name of a parent folder. This is because replace replaces the first occurence, not the last. This can be seen if you try to update the title heading in a file located at `Tests/Test.md`. This PR builds the path on top of the last parent instead of replacing. Since the path is normalized during rename, it's safe even if the file is in the base folder with a path of "/".
|
Good find and thanks for the PR! |
|
Released in 1.6.0 |
|
Thanks! Thanks for all your work on this plugin too! Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, renaming a file through the header fails when the current file basename is contained in the name of a parent folder. This is because replace replaces the first occurence, not the last. This can be seen if you try to update the title heading in a file located at
Tests/Test.md.This PR builds the path on top of the last parent instead of replacing. Since the path is normalized during rename, it's safe even if the file is in the base folder with a path of "/".