-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for underline style headings #73
Conversation
wow that was quick! Thanks a lot for the PR, let me try to get this reviewed today |
Had an hour to spare and your code was easy to follow :) |
The format is currently breaking, could you run |
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When changing underline string from ===
to something else, and 'replace heading style' is enabled, should this replace ===
to the new string?
My assumption without reading the code was that it will force the heading style to be whatever is set in the settings, but currently it doesn't change the underline
Left a few small comments, besides that it looks good to me 👍 |
Think I fixed them all. |
Tested and working great! I'll go ahead and merge this There's still the comment regarding |
If someone uses It might be worth adding some validation to the settings to ensure only a sequence of |
Fixes #72
Comes with lots of options:
The defaults retain the old behaviour.
This is my first TypeScript in a while and my first Obsidian plugin so let me know if I did something stupid.