Added the lockout logic #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| and the message 'Your username or password is incorrect'. | ||
| 7. If the credentials are entered incorrectly three times, the user account |
There was a problem hiding this comment.
@dwmkerr locked out after three attempts? Have you thought about:
- Users deliberately logging each other out.
- How long they're locked out for.
- How we reset them in the backoffice.
There's a lot of work to support this - add a full new spec for the lockout behaviour to the pull request and we can consider it - but this is not a trivial piece of work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the 'lockout' logic that locks the user out after three failed attempts.