Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the lockout logic #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion login/login.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,6 @@ are wrong, the login process is:
* The caption becomes 'login'
* The password box is cleared.
6. Finally, an alert above the login box is shown with the title 'Login Failed'
and the message 'Your username or password is incorrect'.
and the message 'Your username or password is incorrect'.
7. If the credentials are entered incorrectly three times, the user account
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwmkerr locked out after three attempts? Have you thought about:

  1. Users deliberately logging each other out.
  2. How long they're locked out for.
  3. How we reset them in the backoffice.
    There's a lot of work to support this - add a full new spec for the lockout behaviour to the pull request and we can consider it - but this is not a trivial piece of work

is locked out.