Skip to content

Commit

Permalink
fix(types): fix nodenext module resolution compatibility (socketio#4625)
Browse files Browse the repository at this point in the history
The import added in [1] was invalid, because it used an non-exported
class.

Related: socketio#4621

[1]: socketio@6652a3f
  • Loading branch information
igorls authored and darrachequesne committed Feb 20, 2023
1 parent 9dbe945 commit 2aa6636
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 15 deletions.
8 changes: 3 additions & 5 deletions lib/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@ import { createDeflate, createGzip, createBrotliCompress } from "zlib";
import accepts = require("accepts");
import { pipeline } from "stream";
import path = require("path");
import {
attach,
Server as Engine,
import { attach, Server as Engine, uServer } from "engine.io";
import type {
ServerOptions as EngineOptions,
AttachOptions,
uServer,
BaseServer,
} from "engine.io";
import { Client } from "./client";
import { EventEmitter } from "events";
Expand Down Expand Up @@ -41,7 +40,6 @@ import {
SecondArg,
} from "./typed-events";
import { patchAdapter, restoreAdapter, serveFile } from "./uws";
import type { BaseServer } from "engine.io/build/server";

const debug = debugModule("socket.io:server");

Expand Down
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"accepts": "~1.3.4",
"base64id": "~2.0.0",
"debug": "~4.3.2",
"engine.io": "~6.4.0",
"engine.io": "~6.4.1",
"socket.io-adapter": "~2.5.2",
"socket.io-parser": "~4.2.1"
},
Expand Down

0 comments on commit 2aa6636

Please sign in to comment.