Extra volumes 0.2.x #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By manual cherry-pick of 6661451
By merging changes in https://github.com/eWaterCycle/grpc4bmi/pull/69/files into 0.2.x branch
SarahAlidoost
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
@sverhoeven thank you, it works great. To review the docker part, I checkout the branch in the pull request and install grpc4bmi from that branch. The lisflood_testrun_notebook is used to test if the grpc4bmi.bmi_client_docker works with extra_volumes. This test was successful. I did the same for the singularity part but on the Cartesius. The grpc4bmi.bmi_client_singularity works with extra_volumes. The other tests were successful, too.
|
@SarahAlidoost many thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports extra_volumes arg to BmiClientDocker and BmiClientSingularity
Refs #65
Refs #66