Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.2.x: Handle when model value is too big for message #78

Merged
merged 9 commits into from
Aug 11, 2020
Merged

0.2.x: Handle when model value is too big for message #78

merged 9 commits into from
Aug 11, 2020

Conversation

sverhoeven
Copy link
Member

Refs #76

@sverhoeven sverhoeven marked this pull request as ready for review August 11, 2020 06:59
@sverhoeven sverhoeven mentioned this pull request Aug 11, 2020
Closed
nielsdrost
nielsdrost reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@nielsdrost nielsdrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was having some trouble running the tests, but this was not due to this PR, I think.

grpc4bmi/utils.py Show resolved Hide resolved
test/fake_models.py Outdated Show resolved Hide resolved
test/test_subproc.py Show resolved Hide resolved
@sverhoeven sverhoeven merged commit 2d00924 into 0.2.x Aug 11, 2020
@sverhoeven sverhoeven deleted the value-too-big-0.2.x branch August 11, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdrost nielsdrost nielsdrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverhoeven @nielsdrost