-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing lines of events translation #4
Comments
I have a PR Push for it: |
Thank you, these missing lines will be added in the next release |
hi, i've just noticed you are still using the old scripts pre-splitted with
20 chars length, you should be using the original unsplitted version
instead.
I have them stored in this path now:
https://github.com/eadmaster/pcrown/tree/master/script/eng/events
…On Sun, 27 Oct 2024 at 08:09, MiYaku Gaming ***@***.***> wrote:
I have a PR Push for it:
#6 <#6>
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHB347ZT5QBQUCOHGX3FK3Z5SGRPAVCNFSM6AAAAABQVCPFX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZHA4DGNZTGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Thanks, I am still learning this all lol |
I've been using my fork to Translate existing Japanese lines and keeping the original English Lines intact. |
Ok, make sure you are in sync with my latest commit.
…On Tue, 29 Oct 2024, 06:12 MiYaku Gaming, ***@***.***> wrote:
I've been using my fork to Translate existing Japanese lines and keeping
the original English Lines intact.
You can see those Draft PR's on my fork.
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHB34YMQNJYAJ2XVEQ5CHDZ54KNRAVCNFSM6AAAAABQVCPFX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBTGIZDSNRVHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I tried to do a PR of your commits but it seems the readme isn't doing well, not sure how to fix that at all. |
All the missing lines are now translated, will be included in v0.6. |
Add missing lines of events translation, correct typos in the old 2014 SamIAm script.
Full list of files with untranslated lines:
The text was updated successfully, but these errors were encountered: