Skip to content

Commit

Permalink
update config.go (flyteorg#457)
Browse files Browse the repository at this point in the history
* update config.go

[Slack Conversation](https://flyte-org.slack.com/archives/C01P3B761A6/p1657755908722469)
The timeouts for nodes/workflows are configured using different config.go files, depending on the deadlines (such as NodeExecution, NodeActive, and WorkflowActive deadlines).
Specify that the times set by user includes only the time spent running and queued respectively.
Signed-off-by: [email protected]
Signed-off-by: SmritiSatyanV [email protected]

Signed-off-by: SmritiSatyanV <[email protected]>

* Make generate

Signed-off-by: Kevin Su <[email protected]>

Co-authored-by: Kevin Su <[email protected]>
  • Loading branch information
SmritiSatyanV and pingsutw authored Jul 15, 2022
1 parent d7fb99b commit 0031707
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions flytepropeller/pkg/controller/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,9 @@ type NodeConfig struct {

// DefaultDeadlines contains default values for timeouts
type DefaultDeadlines struct {
DefaultNodeExecutionDeadline config.Duration `json:"node-execution-deadline" pflag:",Default value of node execution timeout"`
DefaultNodeActiveDeadline config.Duration `json:"node-active-deadline" pflag:",Default value of node timeout"`
DefaultWorkflowActiveDeadline config.Duration `json:"workflow-active-deadline" pflag:",Default value of workflow timeout"`
DefaultNodeExecutionDeadline config.Duration `json:"node-execution-deadline" pflag:",Default value of node execution timeout that includes the time spent to run the node/workflow"`
DefaultNodeActiveDeadline config.Duration `json:"node-active-deadline" pflag:",Default value of node timeout that includes the time spent queued."`
DefaultWorkflowActiveDeadline config.Duration `json:"workflow-active-deadline" pflag:",Default value of workflow timeout that includes the time spent queued."`
}

// LeaderElectionConfig Contains leader election configuration.
Expand Down
6 changes: 3 additions & 3 deletions flytepropeller/pkg/controller/config/config_flags.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0031707

Please sign in to comment.