Rename dask port from to (flyteorg#315)

Signed-off-by: Bernhard Stadlbauer <[email protected]> Signed-off-by: Bernhard Stadlbauer <[email protected]>
eapolinario · Feb 13, 2023 · 5981c35 · 5981c35
1 parent 5e75228
commit 5981c35
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/go/tasks/plugins/k8s/dask/dask.go b/go/tasks/plugins/k8s/dask/dask.go
@@ -247,7 +247,7 @@ func createSchedulerSpec(cluster plugins.DaskScheduler, clusterName string, defa
 					Env:       defaults.Env,
 					Ports: []v1.ContainerPort{
 						{
-							Name:          "comm",
+							Name:          "tcp-comm",
 							ContainerPort: 8786,
 							Protocol:      "TCP",
 						},
@@ -268,10 +268,10 @@ func createSchedulerSpec(cluster plugins.DaskScheduler, clusterName string, defa
 			},
 			Ports: []v1.ServicePort{
 				{
-					Name:       "comm",
+					Name:       "tcp-comm",
 					Protocol:   "TCP",
 					Port:       8786,
-					TargetPort: intstr.FromString("comm"),
+					TargetPort: intstr.FromString("tcp-comm"),
 				},
 				{
 					Name:       "dashboard",

diff --git a/go/tasks/plugins/k8s/dask/dask_test.go b/go/tasks/plugins/k8s/dask/dask_test.go
@@ -213,7 +213,7 @@ func TestBuildResourceDaskHappyPath(t *testing.T) {
 	schedulerSpec := daskJob.Spec.Cluster.Spec.Scheduler.Spec
 	expectedPorts := []v1.ContainerPort{
 		{
-			Name:          "comm",
+			Name:          "tcp-comm",
 			ContainerPort: 8786,
 			Protocol:      "TCP",
 		},
@@ -240,10 +240,10 @@ func TestBuildResourceDaskHappyPath(t *testing.T) {
 	}
 	expectedSerivcePorts := []v1.ServicePort{
 		{
-			Name:       "comm",
+			Name:       "tcp-comm",
 			Protocol:   "TCP",
 			Port:       8786,
-			TargetPort: intstr.FromString("comm"),
+			TargetPort: intstr.FromString("tcp-comm"),
 		},
 		{
 			Name:       "dashboard",