Remove registration of old panicCounter

Signed-off-by: Jason Parraga <[email protected]>

flyteadmin/pkg/rpc/adminservice/base.go

@@ -5,8 +5,6 @@ import (
 	"fmt"
 	"runtime/debug"
 
-	"github.com/golang/protobuf/proto"
-
 	"github.com/flyteorg/flyte/flyteadmin/pkg/async/cloudevent"
 	eventWriter "github.com/flyteorg/flyte/flyteadmin/pkg/async/events/implementations"
 	"github.com/flyteorg/flyte/flyteadmin/pkg/async/notifications"
@@ -44,17 +42,6 @@ type AdminService struct {
 	Metrics                  AdminMetrics
 }
 
-// Intercepts all admin requests to handle panics during execution.
-func (m *AdminService) interceptPanic(ctx context.Context, request proto.Message) {
-	err := recover()
-	if err == nil {
-		return
-	}
-
-	m.Metrics.PanicCounter.Inc()
-	logger.Fatalf(ctx, "panic-ed for request: [%+v] with err: %v with Stack: %v", request, err, string(debug.Stack()))
-}
-
 const defaultRetries = 3
 
 func NewAdminServer(ctx context.Context, pluginRegistry *plugins.Registry, configuration runtimeIfaces.Configuration,

flyteadmin/pkg/rpc/adminservice/metrics.go

@@ -2,8 +2,6 @@
 package adminservice
 
 import (
-	"github.com/prometheus/client_golang/prometheus"
-
 	"github.com/flyteorg/flyte/flyteadmin/pkg/rpc/adminservice/util"
 	"github.com/flyteorg/flyte/flytestdlib/promutils"
 )
@@ -115,8 +113,7 @@ type descriptionEntityEndpointMetrics struct {
 }
 
 type AdminMetrics struct {
-	Scope        promutils.Scope
-	PanicCounter prometheus.Counter
+	Scope promutils.Scope
 
 	executionEndpointMetrics               executionEndpointMetrics
 	launchPlanEndpointMetrics              launchPlanEndpointMetrics
@@ -137,8 +134,6 @@ type AdminMetrics struct {
 func InitMetrics(adminScope promutils.Scope) AdminMetrics {
 	return AdminMetrics{
 		Scope: adminScope,
-		PanicCounter: adminScope.MustNewCounter("handler_panic",
-			"panics encountered while handling requests to the admin service"),
 
 		executionEndpointMetrics: executionEndpointMetrics{
 			scope:       adminScope,

flyteadmin/pkg/rpc/adminservice/project.go

@@ -79,7 +79,6 @@ func (m *AdminService) GetProject(ctx context.Context, request *admin.ProjectGet
 }
 
 func (m *AdminService) GetDomains(ctx context.Context, request *admin.GetDomainRequest) (*admin.GetDomainsResponse, error) {
-	defer m.interceptPanic(ctx, request)
 	if request == nil {
 		return nil, status.Errorf(codes.InvalidArgument, "Incorrect request, nil requests not allowed")
 	}