Make a copy of WF labels before updating it for Nodes (flyteorg#43)

eapolinario · Dec 12, 2019 · cafc60b · cafc60b
1 parent ae2f2f0
commit cafc60b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/flytepropeller/pkg/controller/nodes/node_exec_context.go b/flytepropeller/pkg/controller/nodes/node_exec_context.go
@@ -107,9 +107,11 @@ func (e execContext) GetLabels() map[string]string {
 
 func newNodeExecContext(_ context.Context, store *storage.DataStore, w v1alpha1.ExecutableWorkflow, node v1alpha1.ExecutableNode, nodeStatus v1alpha1.ExecutableNodeStatus, inputs io.InputReader, maxDatasetSize int64, er events.TaskEventRecorder, tr handler.TaskReader, nsm *nodeStateManager, enqueueOwner func() error) *execContext {
 	md := execMetadata{WorkflowMeta: w}
-	nodeLabels := md.GetLabels()
-	if nodeLabels == nil {
-		nodeLabels = make(map[string]string)
+
+	// Copying the labels before updating it for this node
+	nodeLabels := make(map[string]string)
+	for k, v := range md.GetLabels() {
+		nodeLabels[k] = v
 	}
 	nodeLabels[NodeIDLabel] = utils.SanitizeLabelValue(node.GetID())
 	if tr != nil && tr.GetTaskID() != nil {