Merge pull request #14 from lyft/fix-typo

Variable created would shadow external variable
eapolinario · Sep 18, 2019 · f9f1d75 · f9f1d75
2 parents 6fcd80b + e8594d3
commit f9f1d75
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/flytepropeller/pkg/controller/nodes/task/handler.go b/flytepropeller/pkg/controller/nodes/task/handler.go
@@ -256,9 +256,9 @@ func (h *taskHandler) StartNode(ctx context.Context, w v1alpha1.ExecutableWorkfl
 				logger.Errorf(ctx, "Panic in plugin for TaskType [%s]", task.TaskType())
 			}
 		}()
-		t := h.metrics.pluginExecutionLatency.Start(ctx)
+		s := h.metrics.pluginExecutionLatency.Start(ctx)
 		taskStatus, err = t.StartTask(ctx, taskCtx, task.CoreTask(), nodeInputs)
-		t.Stop()
+		s.Stop()
 	}()
 
 	if err != nil {
@@ -309,9 +309,9 @@ func (h *taskHandler) CheckNodeStatus(ctx context.Context, w v1alpha1.Executable
 				logger.Errorf(ctx, "Panic in plugin for TaskType [%s]", task.TaskType())
 			}
 		}()
-		t := h.metrics.pluginExecutionLatency.Start(ctx)
+		s := h.metrics.pluginExecutionLatency.Start(ctx)
 		taskStatus, err = t.CheckTaskStatus(ctx, taskCtx, task.CoreTask())
-		t.Stop()
+		s.Stop()
 	}()
 
 	if err != nil {