Skip to content

Commit

Permalink
returning 'Undefined' when recovering a SKIPPED node so that the node…
Browse files Browse the repository at this point in the history
… is executed (flyteorg#551)

Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw authored Apr 7, 2023
1 parent 355a140 commit 109bfe7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func (c *nodeExecutor) attemptRecovery(ctx context.Context, nCtx handler.NodeExe
// A recoverable node execution should always be in a terminal phase
switch recovered.Closure.Phase {
case core.NodeExecution_SKIPPED:
return handler.PhaseInfoSkip(nil, "node execution recovery indicated original node was skipped"), nil
return handler.PhaseInfoUndefined, nil
case core.NodeExecution_SUCCEEDED:
fallthrough
case core.NodeExecution_RECOVERED:
Expand Down

0 comments on commit 109bfe7

Please sign in to comment.