Increase LWIP timeouts to avoid MDNS panics #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up the LWIP_ARP setting to increase the LWIP timeout pool to avoid a panic when using SimpleMDNS and TCP clients. Fixes #2650
|
@GUVWAF can you give this a try with your real application? I've added 2 add'l LWIP timer slots and rebuilt everything. Should be microscopic RAM impact and hopefully no OOM panics... |
|
Thanks for the fix and the explanation. Just tried this with the application (Meshtastic, which offers an API over TCP and optionally connects to an MQTT server), and it works fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up the LWIP_ARP setting to increase the LWIP timeout pool to avoid a panic when using SimpleMDNS and TCP clients.
Fixes #2650