Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation and unit conversion for Geosphere 10minute radiation data #998

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

gutzbenj
Copy link
Member

@gutzbenj gutzbenj commented Sep 4, 2023

Dear @mhuber89,

this patch should accommodate the needs to fix the documentation as well as unit conversion mentioned in #988 .

To ensure the right conversion factor I looked it up here: https://hextobinary.com/unit/heatflux/from/wpm2/to/jsm2

Please check the changes and comment below!

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (2b97ab4) 90.92% compared to head (329853f) 90.88%.

❗ Current head 329853f differs from pull request most recent head fd2c97d. Consider uploading reports for the commit fd2c97d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   90.92%   90.88%   -0.05%     
==========================================
  Files         105      105              
  Lines        8716     8718       +2     
  Branches      997      998       +1     
==========================================
- Hits         7925     7923       -2     
- Misses        591      595       +4     
  Partials      200      200              
Flag Coverage Δ
unittests 90.88% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
wetterdienst/provider/geosphere/observation/api.py 99.48% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gutzbenj gutzbenj force-pushed the geosphere branch 3 times, most recently from 206e065 to ce13992 Compare September 4, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant