graphene_rect_union(): schema and implementation mismatch

[ghost]

I see that you've added schemas, that's nice.

But for graphene_rect_union(), the implementation doesn't do what the schema shows:

res->origin.x = MIN (ra.origin.x, rb.origin.x);
res->origin.y = MIN (ra.origin.y, rb.origin.y);

res->size.width = MAX (ra.size.width, rb.size.width);
res->size.height = MAX (ra.size.height, rb.size.height);

In other words, the schema shows the bounding rectangle, but the union() function does something else. That's why I said in the other bug that rectangle union was a strange operation to me.

[ebassi]

That's how the union works for two normalized rectangles: take the minimum of the origin coordinates, and take the maximum of the sizes.

[ghost]

Note that in your schema, the blue outline is bigger than the orange rectangle.

[ebassi]

Yikes, I refactored it and completely borked, it at some point.