matrix: Fix boolean logic in graphene_matrix_to_2d() #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2019 01:26
Looks like a leftover from a previous debugging session that snuck into git.
As a side effect, this fixes an issue where && and || were confused leading to way too many matrices being accepted as 2D when they shouldn't. A new test, matrix/to-2d has been added.
|
Updated the commit after finding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a thinko, where && and || where confused leading to way
too many matrices being accepted as 2D when they shouldn't.
A new test, matrix/is-2d has been added.