Few fixes for Visual Studio builds #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that __vectorcall/ABI is improved in Visual Studio 2017/2019 for 32-bit x86 builds (and tests) of Graphene itself, but is not robust enough for more involved programs, such as GTK master, to run without encountering strange access violations. As a result, disable SSE2 intrinsics for 32-bit x86 for now until the __vectorcall/ABI situation gets improved on later Visual Studio iterations. This affects builds up to the latest Visual Studio 2019 16.4.x, unfortunately.
The -utf-8 compiler flag is only supported since Visual Studio 2015, so if that is not supported, fall back to the former behavior of erroring out on C4819, so that we don't mis-compile things. Note that this means we can build and run Graphene with Visual Studio as-is on Visual Studio 2013 and later, but for building the tests, Visual Studio 2015 or later is required, since Visual Studio 2015 and later is required to build mutest.
We can actually build and use Graphene on Visual Studio 2013 and later, but it does not support enough C99 for the dependent mutest test library that is used for the tests. Issue a warning that one may proceed building Graphene using Visual Studio 2013, but it will come at a cost of having to disable building and running the test programs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This updates the build for Visual Studio builds, as follows:
Support Visual Studio 2013 builds better-re-enable erroring out on C4819 when /utf-8 (a Visual Studio 2015+ feature) is not supported, to avoid mis-compilations, and let people know that it is actually possible to build Graphene as-is with Visual Studio 2013, but at the cost of needing to explicitly disable building and running the tests.
Disable SSE2 builds for all 32-bit x86 Visual Studio builds. This is because although Visual Studio 2017 and 2019 improved on the __vectorcall calling convention (ABI), that needs to be used for 32-bit x86 builds, which is enough for running Graphene itself with the test programs, but this proved to be not enough to run more involved programs, such as GTK master. Note that x64 Visual Studio builds continue to support SSE2/SSE4.1 as they did before, Visual Studio 2013 included.
With blessings, thank you!