meson: Fix check for builtype arguments #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`get_option('buildtype')` will return `'custom'` for most combinations
of `-Doptimization` and `-Ddebug`, but those two will always be set
correctly if only `-Dbuildtype` is set. So we should look at those
options directly.
For the two-way mapping between `buildtype` and `optimization`
+ `debug`, see this table:
https://mesonbuild.com/Builtin-options.html#build-type-options
|
Test failure seems to be unrelated?
|
|
@nirbheek The transient failure in the |
|
Should I re-push till the test passes? |
|
Nah, it's just annoying, and I care very little about 32bit platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_option('buildtype')will return'custom'for most combinationsof
-Doptimizationand-Ddebug, but those two will always be setcorrectly if only
-Dbuildtypeis set. So we should look at thoseoptions directly.
For the two-way mapping between
buildtypeandoptimization+debug, see this table:https://mesonbuild.com/Builtin-options.html#build-type-options
Same change as glib: https://gitlab.gnome.org/GNOME/glib/merge_requests/1433