Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows deployment #77

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: windows deployment #77

merged 1 commit into from
Dec 18, 2023

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Dec 18, 2023

The Jenkinsfile expects the version number of the previous release(s) in the Windows script, not the current one. This version number is used to indicate which of the old Windows versions can be updated to the current one. This is now fixed, re-enabling the Windows update mechanism.

Contributed on behalf of STMicroelectronics

What it does

Instructs within the Jenkinsfile to update the latest.yml of the last stable Windows release

How to test

Once merged, the Jenkins build should succeed, replacing the Windows 1.40.1 latest.yml with the new one

@sdirix sdirix requested a review from jfaltermeier December 18, 2023 11:27
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The Jenkinsfile expects the version number of the previous release(s)
in the Windows script, not the current one. This version number is
used to indicate which of the old Windows versions can be updated to
the current one. This is now fixed, re-enabling the Windows update
mechanism.

Contributed on behalf of STMicroelectronics
@sdirix sdirix force-pushed the fix-windows-update branch from 3dcf36a to f571493 Compare December 18, 2023 11:30
@sdirix sdirix merged commit 8dab182 into master Dec 18, 2023
3 checks passed
@sdirix sdirix deleted the fix-windows-update branch December 18, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants