Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevWorkspace Operator contributions attributes to inject editors into Devfile containers #716

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jan 31, 2023

…itors into Devfile containers

Signed-off-by: Oleksii Orel [email protected]

What does this PR do?

Add DevWorkspace Operator contributions attributes to inject editors into Devfile containers.

What issues does this PR fix or reference?

fixes eclipse-che/che#21738
fixes eclipse-che/che#21563

@olexii4 olexii4 requested a review from ibuziuk January 31, 2023 14:14
@olexii4 olexii4 requested a review from akurinnoy as a code owner January 31, 2023 14:14
@che-bot
Copy link
Contributor

che-bot commented Jan 31, 2023

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 marked this pull request as draft January 31, 2023 14:14
@che-bot
Copy link
Contributor

che-bot commented Jan 31, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Jan 31, 2023

Click here to review and test in web IDE: Contribute

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Jan 31, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Jan 31, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #716 (7de7736) into main (3f02379) will increase coverage by 0.59%.
The diff coverage is 73.34%.

@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
+ Coverage   77.04%   77.64%   +0.59%     
==========================================
  Files         320      320              
  Lines       31369    31193     -176     
  Branches     1836     1840       +4     
==========================================
+ Hits        24169    24219      +50     
+ Misses       7151     6924     -227     
- Partials       49       50       +1     
Flag Coverage Δ
unittests 77.64% <73.34%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rvices/dashboard-backend-client/devWorkspaceApi.ts 58.20% <0.00%> (-3.70%) ⬇️
...ashboard-backend-client/devWorkspaceTemplateApi.ts 45.00% <0.00%> (-5.00%) ⬇️
...rvices/dashboard-backend-client/yamlResolverApi.ts 48.71% <0.00%> (ø)
...oard-frontend/src/store/DevfileRegistries/index.ts 80.00% <0.00%> (-0.05%) ⬇️
...nd/src/store/FactoryResolver/normalizeDevfileV2.ts 28.07% <25.00%> (ø)
...hboard-frontend/src/services/registry/resources.ts 61.90% <50.00%> (+14.17%) ⬆️
...rd-backend/src/routes/api/devworkspaceResources.ts 61.11% <61.11%> (ø)
.../src/routes/api/helpers/getCertificateAuthority.ts 66.66% <66.66%> (ø)
...hboard-frontend/src/store/FactoryResolver/index.ts 87.04% <66.66%> (+1.88%) ⬆️
...shboard-backend-client/devworkspaceResourcesApi.ts 68.00% <68.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-716

@che-bot
Copy link
Contributor

che-bot commented Feb 1, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-716

@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Feb 8, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-716

@che-bot
Copy link
Contributor

che-bot commented Feb 9, 2023

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 marked this pull request as ready for review February 16, 2023 14:27
@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2023

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Feb 28, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 28, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 28, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-716

@che-bot
Copy link
Contributor

che-bot commented Feb 28, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-716

@che-bot
Copy link
Contributor

che-bot commented Feb 28, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 28, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-716

@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit f803205 into main Feb 28, 2023
@olexii4 olexii4 deleted the CHE-21738 branch February 28, 2023 16:55
@che-bot che-bot added this to the 7.62 milestone Feb 28, 2023
@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/201: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants