Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procedures: Add PostgreSQL migration guides #2163

Closed
wants to merge 20 commits into from
Closed

procedures: Add PostgreSQL migration guides #2163

wants to merge 20 commits into from

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 12, 2021

Signed-off-by: Anatolii Bazko [email protected]

What does this pull request change?

  • Add PostgreSQL migration guides

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@tolusha tolusha requested review from rkratky, themr0c and a team as code owners November 12, 2021 13:43
@tolusha tolusha requested a review from svor November 12, 2021 13:43
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <[email protected]>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Signed-off-by: Anatolii Bazko <[email protected]>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@themr0c themr0c added this to the 7.40 milestone Nov 16, 2021
Signed-off-by: Anatolii Bazko <[email protected]>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@themr0c themr0c changed the title chore: Add PostgreSQL migration guides procedures: Add PostgreSQL migration guides Nov 19, 2021
@themr0c
Copy link
Contributor

themr0c commented Jan 25, 2022

@tolusha I see merge conflicts, can you resolve them or do you need assistance?


:context: migration-to-external-database-setup

Follow the procedures below to migrate from internal to external database setup successfully without any data loss.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Follow the procedures below to migrate from internal to external database setup successfully without any data loss.
You can migrate from the internal database to an external database without losing data.


By the 11th of November, 2021, the PostgreSQL version 9.6 came out of support, and {prod-short} team recommends that all users undergo migrating to version 13.

Follow the procedures below to migrate to a newer version of PostgreSQL successfully without any data loss.
Copy link
Contributor

@max-cx max-cx Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Follow the procedures below to migrate to a newer version of PostgreSQL successfully without any data loss.
You can upgrade to a newer version of PostgreSQL without losing data.


:context: migration-from-postgresql-9-to-postgresql-13

By the 11th of November, 2021, the PostgreSQL version 9.6 came out of support, and {prod-short} team recommends that all users undergo migrating to version 13.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a release note to me. If we need to tell this information to customers, I propose that we create a release note and link to this procedure from the release note.
Let me know what you think about this possibility.

Comment on lines +3 to +8
:parent-context-of-migration-from-postgresql-9-to-postgresql-13: {context}

[id="migration-from-postgresql-9-to-postgresql-13_{context}"]
= Migration from PostgreSQL 9 to PostgreSQL 13

:context: migration-from-postgresql-9-to-postgresql-13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:parent-context-of-migration-from-postgresql-9-to-postgresql-13: {context}
[id="migration-from-postgresql-9-to-postgresql-13_{context}"]
= Migration from PostgreSQL 9 to PostgreSQL 13
:context: migration-from-postgresql-9-to-postgresql-13
:parent-context-of-upgrading-postgresql: {context}
[id="upgrading-postgresql_{context}"]
= Upgrading PostgreSQL
:context: upgrading-postgresql


include::partial$snip_verification-che-working.adoc[]

:context: {parent-context-of-migration-from-postgresql-9-to-postgresql-13}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:context: {parent-context-of-migration-from-postgresql-9-to-postgresql-13}
:context: {parent-context-of-upgrading-postgresql}


:context: migration-from-helm-charts-to-operator

Follow the procedures below to migrate from Helm Charts to Operator successfully without any data loss.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Follow the procedures below to migrate from Helm Charts to Operator successfully without any data loss.
You can migrate from Helm Charts to Operator without losing data.

Comment on lines +1 to +2
[id="migration-to-external-database-setup"]
:navtitle: Migration to external database setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[id="migration-to-external-database-setup"]
:navtitle: Migration to external database setup
[id="migration-to-an-external-database-setup"]
:navtitle: Migration to an external database setup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably need to change the file name too.

:keywords: administration-guide, external-database, migration
:page-aliases: .:migration-to-external-database-setup

include::partial$assembly_migration-to-external-database-setup.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have suggested renaming that file too.

:keywords: administration-guide, external-database, migration
:page-aliases: .:migration-to-external-database-setup

include::partial$assembly_migration-to-external-database-setup.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include::partial$assembly_migration-to-external-database-setup.adoc[]
include::partial$assembly_migration-to-an-external-database-setup.adoc[]

Comment on lines 1 to 2
[id="migration-from-postgresql-9-to-postgresql-13"]
:navtitle: Migration from PostgreSQL 9 to PostgreSQL 13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[id="migration-from-postgresql-9-to-postgresql-13"]
:navtitle: Migration from PostgreSQL 9 to PostgreSQL 13
[id="upgrading-postgresql"]
:navtitle: Upgrading PostgreSQL


include::partial$proc_migration_from_postgresql_9_to_postgresql_13.adoc[]
include::partial$assembly_migration-from-postgresql-9-to-postgresql-13.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include::partial$assembly_migration-from-postgresql-9-to-postgresql-13.adoc[]
include::partial$assembly_upgrading-postgresql.adoc[]

@@ -45,8 +45,10 @@
*** xref:define-backup-server-for-operator.adoc[]
** xref:persistent-volumes-backups.adoc[]
** xref:external-database-setup.adoc[]
** xref:migration-to-external-database-setup.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** xref:migration-to-external-database-setup.adoc[]
** xref:migration-to-an-external-database-setup.adoc[]

@@ -45,8 +45,10 @@
*** xref:define-backup-server-for-operator.adoc[]
** xref:persistent-volumes-backups.adoc[]
** xref:external-database-setup.adoc[]
** xref:migration-to-external-database-setup.adoc[]

* xref:migration-from-postgresql-9-to-postgresql-13.adoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* xref:migration-from-postgresql-9-to-postgresql-13.adoc[]
* xref:upgrading-postgresql.adoc[]

Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anatolii, I reviewed the files. If you go through my suggestions and apply those that you agree with, then after that I will clone this branch and review and preview this PR locally to make any remaining edits, and then you will see/approve my final changes when I open a PR to your branch.

@max-cx max-cx requested a review from a team as a code owner October 26, 2022 08:06
@github-actions
Copy link

github-actions bot commented Oct 26, 2022

⚡️ Deploying pull request preview...

@max-cx
Copy link
Contributor

max-cx commented Oct 26, 2022

I committed/applied some of my minor suggestions (like adding the and $) to save Anatolii's effort and time reviewing my suggested changes.

@max-cx
Copy link
Contributor

max-cx commented Nov 30, 2022

Closing this PR after discussing it with @tolusha.

@max-cx max-cx closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants