Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devworkspace operator metrics docs #2276

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Apr 4, 2022

What does this pull request change?

Fixes the devworkspace-operator monitoring docs prometheus config files.

What issues does this pull request fix or reference?

References eclipse-che/che#21283

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@dkwon17 dkwon17 requested review from rkratky and themr0c as code owners April 4, 2022 22:41
@github-actions
Copy link

github-actions bot commented Apr 4, 2022

Click here to review and test in web IDE: Contribute

dkwon17 and others added 7 commits April 5, 2022 16:35
…space-operator-metrics-with-prometheus.adoc

Co-authored-by: Max Leonov <[email protected]>
…space-operator-metrics-with-prometheus.adoc

Co-authored-by: Max Leonov <[email protected]>
…space-operator-metrics-with-prometheus.adoc

Co-authored-by: Max Leonov <[email protected]>
…space-operator-metrics-with-prometheus.adoc

Co-authored-by: Max Leonov <[email protected]>
…space-operator-metrics-with-prometheus.adoc

Co-authored-by: Max Leonov <[email protected]>
…space-operator-metrics-with-prometheus.adoc

Co-authored-by: Max Leonov <[email protected]>
…ce-operator-metrics-on-grafana-dashboards.adoc

Co-authored-by: Max Leonov <[email protected]>
@dkwon17
Copy link
Contributor Author

dkwon17 commented Apr 5, 2022

Thank you for the suggestions @max-cx , I agree with your suggestions and I've applied them

Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibuziuk ibuziuk merged commit 2494861 into eclipse-che:master Apr 6, 2022
@themr0c themr0c added this to the 7.44 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants