Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procedures: Configuring workspace target namespace, Provisioning namespaces #2301

Merged
merged 18 commits into from
Apr 27, 2022
Merged

procedures: Configuring workspace target namespace, Provisioning namespaces #2301

merged 18 commits into from
Apr 27, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Apr 21, 2022

Configuring workspace target namespace, Provisioning namespaces

references: eclipse-che/che#21284

What does this pull request change

Update configuring-namespace-strategies

Firefox_Screenshot_2022-04-26T14-06-33 568Z

Firefox_Screenshot_2022-04-26T14-06-49 187Z

Firefox_Screenshot_2022-04-26T14-07-04 905Z

What issues does this pull request fix or reference

Remove "namespace strategy" concept.
Refresh with current situation.

Specify the version of the product this pull request applies to

Pull request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@themr0c themr0c added this to the 7.46 milestone Apr 21, 2022
@themr0c themr0c requested review from l0rd and ibuziuk April 21, 2022 11:48
@themr0c themr0c requested a review from rkratky as a code owner April 21, 2022 11:48
@themr0c themr0c self-assigned this Apr 21, 2022
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@ibuziuk ibuziuk requested a review from metlos April 21, 2022 13:07
@themr0c themr0c requested a review from ibuziuk April 22, 2022 15:18
@themr0c
Copy link
Contributor Author

themr0c commented Apr 22, 2022

Tested with Che on Minikube.

However, I am not sure how to reproduce the prerequisite "The workspace user cannot create namespaces on {orch-name}." for the second procedure. (Meaning that step 1 is sufficient). Therefore, for the next steps, the current state reflects what is created in nominal conditions.

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @themr0c. It's clear and goes straight to the point. I have added a few comments.

@themr0c
Copy link
Contributor Author

themr0c commented Apr 26, 2022

Applied suggestions. Ready for language review I think.

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic 👍

themr0c and others added 10 commits April 27, 2022 10:46
@themr0c themr0c merged commit f18b2e1 into eclipse-che:master Apr 27, 2022
@themr0c themr0c deleted the configuring-namespaces branch April 27, 2022 08:53
max-cx pushed a commit to max-cx/che-docs that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants