Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating minikube and crc installation guides #2302

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Apr 22, 2022

What does this pull request change

  • update crc and minikube installation instructions
  • remove Running Minikube inside an LXC container SOP (have not verified the instructions which are in any case not related to Eclipse Che)

What issues does this pull request fix or reference

part of eclipse-che/che#21284

Specify the version of the product this pull request applies to

master

Pull request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@ibuziuk ibuziuk requested review from rkratky and themr0c as code owners April 22, 2022 09:34
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@ibuziuk ibuziuk requested a review from l0rd April 22, 2022 09:35
@ibuziuk ibuziuk force-pushed the install_locally branch 2 times, most recently from 1bae85b to 37321ef Compare April 22, 2022 09:42
@themr0c
Copy link
Contributor

themr0c commented Apr 22, 2022

CRC: The default value for the memory property is 9216. It's maybe sufficient now, or do we still need 12G?
https://access.redhat.com/documentation/en-us/red_hat_codeready_containers/2.0/html-single/getting_started_guide/index#configuring-the-instance_gsg

@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 22, 2022

we should stick to 12 I belive

----

.. Initiate the `oc` command line interface within CRC:
.. Enable access to the `oc` command line interface embedded in CodeReady Containers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should happen after crc start, or you receive the error:

eval $(crc oc-env)
Machine does not exist. Use 'crc start' to create it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions in ibuziuk#3

  • Use CodeReady containers rather than CRC
  • Fix steps numbering.
  • Tested the procedure: removing obsolete commands, reordering commands.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themr0c applied, thanks

* Use CodeReady containers rather than CRC
* Tested the procedure: removing obsolete commands.
@themr0c themr0c merged commit 5a39ed0 into eclipse-che:master Apr 26, 2022
@themr0c themr0c added this to the 7.46 milestone Apr 26, 2022
max-cx pushed a commit to max-cx/che-docs that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants