-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: helmcharts to deploy Eclipse Che #1184
Conversation
helmcharts/Chart.yaml
Outdated
# | ||
|
||
apiVersion: v1 | ||
description: A Helm chart for deploying Eclipse Che to Kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: A Helm chart for deploying Eclipse Che to Kubernetes | |
description: A Helm chart for deploying Eclipse Che on a Kubernetes |
helmcharts/README.md
Outdated
|
||
### Helm Chart Install | ||
|
||
Create a Namespace and install the helm chart for Eclipse Che. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a Namespace and install the helm chart for Eclipse Che. | |
Create a Namespace and install the helm chart for Eclipse Che Operator. |
helmcharts/README.md
Outdated
|
||
### Helm Versions | ||
|
||
Helm charts are only tested with Helm version 3.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try and detect minimal version and put something like 3.x.y+
here.
helmcharts/README.md
Outdated
- [Charts](#charts) | ||
- [Kubernetes Versions](#kubernetes-versions) | ||
- [Helm Versions](#helm-versions) | ||
- [Helm Chart Install](#helm-chart-install) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helm Chart Installation
or Install the Helm Chart
helmcharts/README.md
Outdated
|
||
- [Charts](#charts) | ||
- [Kubernetes Versions](#kubernetes-versions) | ||
- [Helm Versions](#helm-versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required Helm version
?
helmcharts/README.md
Outdated
# Eclipse Che Helm Charts | ||
|
||
- [Charts](#charts) | ||
- [Kubernetes Versions](#kubernetes-versions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Required Kubernetes version
?
@@ -0,0 +1,33 @@ | |||
# Eclipse Che Helm Charts | |||
|
|||
- [Charts](#charts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me none of the headlines was clear. Maybe we should have:
Title
- Prerequisites (K8s & Helm versions)
- Installation
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
Signed-off-by: Anatolii Bazko <[email protected]>
@mmorhun |
/retest |
@tolusha: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Anatolii Bazko [email protected]
What does this PR do?
Introduce Helm charts to deploy Eclipse Che
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20552
How to test this PR?
See helmcharts/README.md
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.